Open
Conversation
added 2 commits
April 21, 2016 12:02
Owner
|
hi, thanks for the contribution, but i don't really have time to review/test the changes, so please create a new fork/demo site and I will link to this as "improved blog" on zeroblog |
added 2 commits
April 21, 2016 21:07
when selecting posts, select count(*) from post as first row so we can do better page display
previously only show prev/next, hard to jump. this improve it by: support jump to first/last page show current page and neighbour page links (instead of prev/next) if not all next pages can showup, ... added to last link to notice user
Author
|
I've create a demo blog for review here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these two patch based on my previously coffeelint work, it supports better pager.
page links may be less than it should be , when applyPagerdata called, whole page didn't layout completely so it needs further work. I'm not good at html so I just create this pull, hopes others can improve it